DEPR: casting strings to float in to_datetime with unit #50909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

MarcoGorelli merged 2 commits into pandas-dev:main from jbrockmendel:depr-unit-behavior

Jan 26, 2023

Member

jbrockmendel commented Jan 20, 2023

closes API: to_datetime with unit changes how strings are interpreted #50735 (Replace xxxx with the GitHub issue number)
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added type annotations to new arguments/methods/functions.
Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

DEPR: casting strings to float in to_datetime with unit

cf71fab

mroeschke requested a review from MarcoGorelli

January 23, 2023 19:09

mroeschke added the Deprecate label

mroeschke reviewed

View reviewed changes

Member

mroeschke left a comment

I guess this is okay (+0) although it makes to_datetime a little less convenient.

MarcoGorelli approved these changes

View reviewed changes

Member

MarcoGorelli left a comment

Looks good to me

Reckon the "inverse" should be deprecated as well, i.e. parsing numeric with format as strings, like

In [3]: to_datetime([20200101], format='%Y%m%d') Out[3]: DatetimeIndex(['2020-01-01'], dtype='datetime64[ns]', freq=None)

?

pandas/io/json/_json.py

Comment on lines +1216 to +1218

       except OverflowError:  
     return data, False  
     except (TypeError, ValueError):  
 

Member

MarcoGorelli Jan 24, 2023 •

edited

Loading

is this just to avoid hitting the warning later in to_datetime(new_data, errors="raise", unit=date_unit), which would be outofbounds anyway?

Member Author

jbrockmendel Jan 24, 2023

correct

Member Author

jbrockmendel commented Jan 24, 2023

Reckon the "inverse" should be deprecated as well, i.e. parsing numeric with format as strings, like

That definitely seems like a potential footgun, no idea how common that is in the wild.

Merge branch 'main' into depr-unit-behavior

3b73bc5

MarcoGorelli added the Datetime label

MarcoGorelli added this to the 2.0 milestone

MarcoGorelli merged commit 8448d39 into pandas-dev:main

jbrockmendel deleted the depr-unit-behavior branch

January 26, 2023 16:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment