Skip to content

Conversation

@lithomas1
Copy link
Contributor

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.
@phofl
Copy link
Member

phofl commented Feb 11, 2023

They are still building here, probably still buggy?

@lithomas1
Copy link
Contributor Author

They are still building here, probably still buggy?

They still go, but exit early. There's no way to skip them conditionally once the job has started.

@phofl
Copy link
Member

phofl commented Feb 11, 2023

Ah so there is no way to skip them completely like gha?

@lithomas1
Copy link
Contributor Author

Ah so there is no way to skip them completely like gha?

Unfortunately not. The only thing that I can skip on (before the job starts) is branches.

@lithomas1 lithomas1 added the Build Library building on various platforms label Feb 11, 2023
@lithomas1 lithomas1 merged commit 031e9bb into pandas-dev:main Feb 11, 2023
@lithomas1 lithomas1 deleted the fix-circleci branch February 11, 2023 20:48
@lithomas1
Copy link
Contributor Author

Looks like this works so I'm just going to put it in.

@phofl
Copy link
Member

phofl commented Feb 11, 2023

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build Library building on various platforms

2 participants