Skip to content

BUG: Fix Grouper with a datetime key in conjunction with another key #51414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 8, 2023
Merged

BUG: Fix Grouper with a datetime key in conjunction with another key #51414

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
53777cd
Fix issue, add test
juleek Feb 15, 2023
dde4665
Merge branch 'main' into work_in_progress
juleek Feb 23, 2023
212a3cf
Merge branch 'main' into work_in_progress
juleek Mar 18, 2023
a0e5a08
fix conflict
juleek Mar 18, 2023
132b46b
fix conflict
juleek Mar 18, 2023
66bf4c8
bug description moved to 2.1.0
juleek Mar 18, 2023
d42e081
Merge branch 'main' into work_in_progress
juleek Mar 23, 2023
124b4bc
Merge branch 'main' into work_in_progress
juleek Mar 31, 2023
bc4b969
fixed pre-commit
juleek Mar 31, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixed pre-commit
  • Loading branch information
@juleek
juleek committed Mar 31, 2023
commit bc4b969e8c0b13b62a70ddd293c39baa11a2ea4b
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v2.1.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,8 @@ Groupby/resample/rolling
grouped :class:`Series` or :class:`DataFrame` was a :class:`DatetimeIndex`, :class:`TimedeltaIndex`
or :class:`PeriodIndex`, and the ``groupby`` method was given a function as its first argument,
the function operated on the whole index rather than each element of the index. (:issue:`51979`)
- Bug in :meth:`GroupBy.var` failing to raise ``TypeError`` when called with datetime64 or :class:`PeriodDtype` values (:issue:`52128`)
- Bug in :meth:`GroupBy.groups` with a datetime key in conjunction with another key produced incorrect number of group keys (:issue:`51158`)
- Bug in :meth:`GroupBy.var` failing to raise ``TypeError`` when called with datetime64 or :class:`PeriodDtype` values (:issue:`52128`)
-

Reshaping
Expand Down