BUG: Timedelta comparisons with very large pytimedeltas overflowing #51538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mroeschke reviewed Feb 21, 2023
pandas/_libs/tslibs/timedeltas.pyx Outdated
| elif op == Py_NE: | ||
| return True | ||
| elif op == Py_LE or op == Py_LT: | ||
| return self.days <= other.days |
Member
There was a problem hiding this comment.
- Shouldn't we use
<=orPY_LEand<forPy_LT? - What about the other components?
Member Author
There was a problem hiding this comment.
hmm i wrote this with self.unit == "ns" in mind, in which case if it overflows we really just need to know which direction it overflowed. but with "s"/"ms" this could be subtly wrong. will update w/ tests.
Contributor
| This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
Member Author
| updated+green |
mroeschke approved these changes Mar 27, 2023
Member
| Thanks @jbrockmendel |
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 27, 2023
…rge pytimedeltas overflowing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.