REF: de-duplicate precision_from_unit attempt 2 #51594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mroeschke added Refactor 
MarcoGorelli approved these changes Feb 24, 2023
Member
MarcoGorelli left a comment
MarcoGorelli left a comment There was a problem hiding this comment.
Looks good - left a comment about the error from precision_from_unit not propagating through get_conversion_factor, but feel free to ignore if you disagree, not a blocker
| m = multiplier // 1_000_000_000 | ||
| else: | ||
| raise ValueError(f"cannot cast unit {unit}") | ||
| m = get_conversion_factor(reso, out_reso) |
Member
There was a problem hiding this comment.
if get_conversion_factor raises, then precision_from_unit wouldn't propagate the error - perhaps a note could be made about this in the docstring, alongside the current note?
Member Author
There was a problem hiding this comment.
comment sounds good
Member Author
There was a problem hiding this comment.
to keep from clogging the CI, mind if i add this comment in my next CLN: assorted branch?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
precision_from_unit is getting called in situations where it shouldn't be.