Skip to content

BLD: Try g0 on macos? #51971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 15, 2023
Merged

BLD: Try g0 on macos? #51971

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a4790e8
BLD: Try g0 on macos?
lithomas1 Mar 14, 2023
3cc5fa4
try just g0
lithomas1 Mar 14, 2023
fe19aa7
Update pyproject.toml
lithomas1 Mar 15, 2023
7c2a5d8
Update pyproject.toml
lithomas1 Mar 15, 2023
54f9dee
Merge branch 'main' into strip-macos
lithomas1 Mar 15, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ parentdir_prefix = "pandas-"
[tool.cibuildwheel]
skip = "cp36-* cp37-* pp37-* *-manylinux_i686 *_ppc64le *_s390x *-musllinux*"
build-verbosity = "3"
environment = { LDFLAGS="-Wl,--strip-all" }
environment = {LDFLAGS="-Wl,--strip-all" }
test-requires = "hypothesis>=6.34.2 pytest>=7.0.0 pytest-xdist>=2.2.0 pytest-asyncio>=0.17"
test-command = "python {project}/ci/test_wheels.py"

Expand All @@ -166,7 +166,7 @@ test-command = ""
# macOS doesn't support stripping wheels with linker
# https://github.com/MacPython/numpy-wheels/pull/87#issuecomment-624878264
select = "*-macosx*"
environment = ""
environment = {CFLAGS="-g0"}
Copy link
Member

@WillAyd WillAyd Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find. a bit orthogonal but wonder if we should strip all symbols here too
Copy link
Member

@WillAyd WillAyd Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess it would help if I read the comment two lines up

[[tool.cibuildwheel.overrides]]
select = "*-win32"
Expand Down