WARN: Only warn about inconsistent parsing if there are multiple non-null elements #52195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MarcoGorelli added Datetime MarcoGorelli force-pushed the only-warn-if-multiple-elements branch from 686a72e to 44d0e9f Compare 
WillAyd reviewed Mar 26, 2023
| ) | ||
| # If there are multiple non-null elements, warn about | ||
| # how parsing might not be consistent | ||
| if tslib.first_non_null(arr[first_non_null + 1 :]) != -1: |
Member
There was a problem hiding this comment.
Only minor nit I'd have is to add an explicit if first_non_null == len(arr) check preceding this. It doesn't have any impact as long as this stays a purely Python function, but if someone tried to convert down to C I'm not sure how slicing beyond the length of the array would work
Member
There was a problem hiding this comment.
Ignore this. Thought this was a pyx file
mroeschke approved these changes Mar 27, 2023
Member
| Thanks @MarcoGorelli |
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 27, 2023
…ing if there are multiple non-null elements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Not sure this needs a whatsnew note as it could just be considered part of the PDEP4 changes, which haven't yet reached user-facing status
The idea here is to only warn if there are at least 2 non-null elements - otherwise, a single element can't be inconsistently-parsed :)