Skip to content

REF: move methods from base to Index #52447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 7, 2023
Merged

REF: move methods from base to Index #52447

merged 4 commits into from
Apr 7, 2023

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Apr 5, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.
@topper-123
Copy link
Contributor

topper-123 commented Apr 5, 2023

I've merged #52428, so I think this should be rebased to avoid merge issues here.
@topper-123 topper-123 added Refactor Internal refactoring of code Index Related to the Index class or subclasses Series Series data structure labels Apr 5, 2023
@topper-123 topper-123 added this to the 2.1 milestone Apr 5, 2023
topper-123
topper-123 reviewed Apr 6, 2023
View reviewed changes
Copy link
Contributor

@topper-123 topper-123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can return ndframe.method(self, ...) be replaced with return super().method(...) for many methods here?
pandas/core/series.py
@doc(NDFrame.isna, klass=_shared_doc_kwargs["klass"]) # type: ignore[has-type]
def isna(self) -> Series: # type: ignore[override]
def isna(self) -> Series:
return NDFrame.isna(self)
Copy link
Contributor

@topper-123 topper-123 Apr 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return super().isna()?

Same question below.
Copy link
Member Author

@jbrockmendel jbrockmendel Apr 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avoiding super bc i always have to check which parent class it refers to
@mroeschke mroeschke merged commit d5bfd2b into pandas-dev:main Apr 7, 2023
@mroeschke
Copy link
Member

mroeschke commented Apr 7, 2023

Thanks @jbrockmendel
@jbrockmendel jbrockmendel deleted the ref-less-base branch April 7, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Index Related to the Index class or subclasses Refactor Internal refactoring of code Series Series data structure

3 participants

@jbrockmendel @topper-123 @mroeschke