BUG: Adds missing raises for numpy.timedelta64[M/Y] in pandas.Timedelta #53421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
|
Contributor Author
| Looking at the 3 failed tests:
My assumption is that the correct approach would be to alter tests to now expect a value error to be thrown but I'm a little unsure if the is the right mentality. I'm a little unsure of the best approach though, any guidance would appreciated. |
Contributor Author
| Went ahead and updated the test to reflect the newly added raise condition. |
mroeschke reviewed May 30, 2023
mroeschke reviewed May 30, 2023
mroeschke added Error Reporting mroeschke reviewed Jun 6, 2023
Contributor Author
| Finally ready... thanks for the patience @mroeschke |
Contributor Author
| Anything else needed here? |
mroeschke reviewed Jun 13, 2023
mroeschke reviewed Jun 13, 2023
mroeschke approved these changes Jun 20, 2023
Member
| Thanks @mcgeestocks |
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
…ta (pandas-dev#53421) * adds raise for numpy Y and M conversion in Timedelta * fix failing tests * update raise lang * alternative approach * add missing periods * switch to cimport * add cython directive * switch to inline cython directive * remove unsupported td operation * adds whatnew update * remove whitespace * adds test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.