BUG: Fix failing hash function for certain non-ns resolution Timedeltas #54037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jbrockmendel reviewed Jul 7, 2023
mroeschke added the Non-Nano 
MarcoGorelli approved these changes Jul 7, 2023
Member
MarcoGorelli left a comment
MarcoGorelli left a comment There was a problem hiding this comment.
should be good, thanks @harahu !
mroeschke approved these changes Jul 7, 2023
Member
| Thanks @harahu |
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
…ta`s (pandas-dev#54037) * Add reproducing test * Attempt fix * Add GH reference * Add whatsnew entry * Pre-commit after the fact
harahu changed the title TimedeltasTimedeltas Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I noticed that hashing certain large
pd.Timedeltas resultet in anOutOfBoundsTimedeltaexception, which shouldn't happen.In the hash implementation there is seems to be an attempt at catching this error, as the offending line is wrapped in a
tryclause, but, theexceptclause catches anOverflowErrorinstead. The call that raisesOutOfBoundsTimedeltadoes so when itself catches anOverflowError, so my interpretation is that the intention was for the hash implementation to catch theOutOfBoundsTimedelta. My changes reflect this. I've also added a test reproducing the issue.doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.