Changed read_csv type hint for na_values and added tests Issue#53813

[kvn4]

• closes BUG: read_csv type hint for na_values should include non-iterables as valid arguments #53813
• Tests added and passed if fixing a bug or adding a new feature
• All code checks passed.
• Added type annotations to new arguments/methods/functions.

[twoertwein]

You could remove None if you like to, it is Hashable.

[kvn4]

Hi @twoertwein and @lithomas1 thank you for the feedback. Do you know where the ellipses issue could be coming from? I only changed the na_values type hint for the read_csv() function.

[twoertwein]

Hi @twoertwein and @lithomas1 thank you for the feedback. Do you know where the ellipses issue could be coming from? I only changed the na_values type hint for the read_csv() function.

You seem to have changed it :) You can always use git add --patch to confirm individual changes you want to add.

You can simply replace = ... with = None in the non-overload definition.

The easiest way to remove the test is probably git checkout <commit id from before your changes> pandas/tests/io/parser/test_na_values.py and then add and commit that.

[kvn4]

Hi @twoertwein do the changes I made look good?

[twoertwein]

Hi @twoertwein do the changes I made look good?

Now you use = None everywhere. You want = None for the function definition that doesn't have the @overload but otherwise use = ....

It might be better to use Sequence instead of Iterable (not sure whether any iterable is accepted).

You can remove the test changes you made.

[kvn4]

Hi @twoertwein do the changes I made look good?

Now you use = None everywhere. You want = None for the function definition that doesn't have the @overload but otherwise use = ....

It might be better to use Sequence instead of Iterable (not sure whether any iterable is accepted).

You can remove the test changes you made.

Thank you for the feedback. I made the changes

[twoertwein]

Thanks @kvn4 !