Skip to content

refactor grouper __iter__ #54544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2023
Merged

refactor grouper __iter__ #54544

merged 1 commit into from
Aug 19, 2023

Conversation

@taytzehao
Copy link
Contributor

@taytzehao taytzehao commented Aug 14, 2023

Removed the __iter__ overload that was introduced in #51414. The logic accessing the grouping_vector for was introduced #53088
@taytzehao taytzehao requested a review from rhshadrach as a code owner August 14, 2023 16:23
rhshadrach
rhshadrach approved these changes Aug 19, 2023
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@rhshadrach rhshadrach added the Refactor Internal refactoring of code label Aug 19, 2023
@rhshadrach rhshadrach added this to the 2.2 milestone Aug 19, 2023
@rhshadrach rhshadrach merged commit 9d70a49 into pandas-dev:main Aug 19, 2023
@rhshadrach
Copy link
Member

rhshadrach commented Aug 19, 2023

Thanks @taytzehao!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Groupby Refactor Internal refactoring of code

3 participants

@taytzehao @rhshadrach @mroeschke