Skip to content

CLN: do not import Axes/Artist/Figure from matplotlib.pyplot #55192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2023
Merged

CLN: do not import Axes/Artist/Figure from matplotlib.pyplot #55192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
CLN: do not import Axes/Artist from matplotlib.pyplot
  • Loading branch information
@twoertwein
twoertwein committed Sep 18, 2023
commit dd22e4fd3ef51e7c24e03d563fe56020d421ea22
7 changes: 4 additions & 3 deletions pandas/_testing/asserters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,22 +416,23 @@ def assert_attr_equal(attr: str, left, right, obj: str = "Attributes") -> None:


def assert_is_valid_plot_return_object(objs) -> None:
import matplotlib.pyplot as plt
from matplotlib.artist import Artist
from matplotlib.axes import Axes

if isinstance(objs, (Series, np.ndarray)):
for el in objs.ravel():
msg = (
"one of 'objs' is not a matplotlib Axes instance, "
f"type encountered {repr(type(el).__name__)}"
)
assert isinstance(el, (plt.Axes, dict)), msg
assert isinstance(el, (Axes, dict)), msg
else:
msg = (
"objs is neither an ndarray of Artist instances nor a single "
"ArtistArtist instance, tuple, or dict, 'objs' is a "
f"{repr(type(objs).__name__)}"
)
assert isinstance(objs, (plt.Artist, tuple, dict)), msg
assert isinstance(objs, (Artist, tuple, dict)), msg


def assert_is_sorted(seq) -> None:
Expand Down