ENH: Improve error message when constructing period with invalid freq #55940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
natmokval added Frequency 
Contributor Author
| @MarcoGorelli, could you please take a look at this PR? |
MarcoGorelli approved these changes Nov 14, 2023
Member
MarcoGorelli left a comment
MarcoGorelli left a comment There was a problem hiding this comment.
Awesome stuff, I love a good error message before all these deprecations hit users
The if name.startswith complexity will disappear after the deprecation cycle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
xref #55792, #52064
Improved error message when constructing period with offsets frequencies deprecated for period such as "ME" or "YE-DEC".
the reason: we see the error message:
Invalid frequency: "..."instead of the message:for Period, please use "..." instead of "..."