REF: Remove un-used attribute-pinning in plotting #55944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mroeschke reviewed Nov 20, 2023
Member
mroeschke left a comment
mroeschke left a comment There was a problem hiding this comment.
I think these are our custom attributes so these should be safe to remove. Mind merging main?
Contributor
| I also believe that these are attributes that Pandas monkey-patches onto Matplotlib objects. If you want to stash state related to unit conversion you can use the attn @ksunden |
mroeschke approved these changes Nov 21, 2023
Member
| Thanks @jbrockmendel |
3 tasks
| This commit appears to be causing an order of magnitude performance issue when plotting with a DatetimeIndex. See #57035 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.xref #54485
@tacaswell can you confirm that matplotlib doesn't use any of these internally? Removing these doesn't break any of our tests locally, but a lot of our plotting tests are basically smoke-tests.