Skip to content

ENH: Implement categorical accessor for arrow arrays #56670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

ENH: Implement categorical accessor for arrow arrays #56670

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2791999
ENH: Start implementing categorical accessor for arrow arrays
phofl Dec 28, 2023
8c376d0
Fix tests
phofl Dec 28, 2023
aa541d9
Fixup
phofl Dec 28, 2023
abb8435
Merge remote-tracking branch 'upstream/main' into cat
phofl Jan 6, 2024
b266a26
Sync
phofl Jan 6, 2024
30a7c73
Optimize for same category chunks
phofl Jan 6, 2024
99dbf83
Add add categories
phofl Jan 6, 2024
aa675f8
Raise if categories are different
phofl Jan 6, 2024
e4ae336
Implement remaining accessors
phofl Jan 6, 2024
d67ac11
Fixup
phofl Jan 6, 2024
caf75c1
Fixup windows
phofl Jan 6, 2024
ea9011c
Fixup
phofl Jan 6, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests
  • Loading branch information
@phofl
phofl committed Dec 28, 2023
commit 8c376d0573969c5384dd250070c6a8bbb4a53360
11 changes: 7 additions & 4 deletions pandas/tests/series/accessors/test_cat_accessor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,11 @@
timedelta_range,
)
import pandas._testing as tm
from pandas.core.arrays.categorical import CategoricalAccessor
from pandas.core.indexes.accessors import Properties
from pandas.core.indexes.accessors import (
CategoricalProperties,
CombinedCategoricalAccessor,
Properties,
)


class TestCatAccessor:
Expand Down Expand Up @@ -54,9 +57,9 @@ def test_cat_accessor(self):
def test_cat_accessor_api(self):
# GH#9322

assert Series.cat is CategoricalAccessor
assert Series.cat is CombinedCategoricalAccessor
ser = Series(list("aabbcde")).astype("category")
assert isinstance(ser.cat, CategoricalAccessor)
assert isinstance(ser.cat, CategoricalProperties)

invalid = Series([1])
with pytest.raises(AttributeError, match="only use .cat accessor"):
Expand Down