Skip to content

BUG: DataFrame.join inconsistently setting result index name #56948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 23, 2024
Merged

BUG: DataFrame.join inconsistently setting result index name #56948

merged 5 commits into from
Jan 23, 2024

Conversation

@lukemanley
Copy link
Member

@lukemanley lukemanley commented Jan 19, 2024

@lukemanley lukemanley added Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Jan 19, 2024
@lukemanley lukemanley added this to the 3.0 milestone Jan 19, 2024
rhshadrach
rhshadrach approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I noticed a small cleanup but doesn't have to be handled here.
@mroeschke mroeschke merged commit fe244ba into pandas-dev:main Jan 23, 2024
@mroeschke
Copy link
Member

mroeschke commented Jan 23, 2024

Thanks @lukemanley
@mroeschke
Copy link
Member

mroeschke commented Jan 25, 2024

I discovered that there's a get_op_result_name. Looks like it's mostly used numerical ops/combine as of now. Maybe we should be using that here
@lukemanley lukemanley mentioned this pull request Jan 26, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode

3 participants

@lukemanley @mroeschke @rhshadrach