CLN: remove from PeriodIndex.asfreq unnecessary raising ValueError for invalid period freq #57300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| @MarcoGorelli, could you please take a look at this PR? |
MarcoGorelli approved these changes Feb 8, 2024
Member
MarcoGorelli left a comment
MarcoGorelli left a comment There was a problem hiding this comment.
nice, good to clean up unnecessary branches
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
…r invalid period freq (pandas-dev#57300) remove from asfreq unnecessary raising ValueError, correct tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
xref #56945
removed from
PeriodIndex.asfrequnnecessary raising ValueError for invalid period freq. Now we raise this ValueError for invalid period freq into_offset.