Skip to content

BUG: Fix dataframe.update not updating dtype #55509 v2 #57637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 2, 2024
Merged

BUG: Fix dataframe.update not updating dtype #55509 v2 #57637

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
93ea131
TST: add a test for preserving dtype while calling frame.update (#55509)
aureliobarbosa Feb 26, 2024
eb963df
TST: Add a test for frame.update raising on duplicate argument indexe…
aureliobarbosa Feb 26, 2024
d5a1085
TST: frame.update accepts duplicate frame index with unique argument…
aureliobarbosa Feb 26, 2024
02c1b77
BUG: fix dataframe.update not preserving dtypes (#55509)
aureliobarbosa Feb 27, 2024
5169022
DOC: Add line indicating bug fix #55509
aureliobarbosa Feb 27, 2024
d7f63a1
DOC: add note on duplicate indices on parameter other (#55509)
aureliobarbosa Feb 28, 2024
1fd2be9
TST: assure test_update_preserve_dtype checks dtype
aureliobarbosa Mar 1, 2024
d948e0a
TST: assure test_update_on_duplicate_frame_unique_argument_index chec…
aureliobarbosa Mar 1, 2024
dbdff5c
TST: Use np.intc instead of np.int64 on dtype tests for frame.update …
aureliobarbosa Mar 1, 2024
b2c915f
Merge remote-tracking branch 'upstream/main' into fix_gh55509_v2
aureliobarbosa Mar 1, 2024
f9d601a
Merge remote-tracking branch 'upstream/main' into fix_gh55509_v2
aureliobarbosa Mar 1, 2024
6de3fce
DOC: Fix separator size (#55509). Minor issue.
aureliobarbosa Mar 1, 2024
a62684f
DOC: fix error messages on frame.update (PR #57637)
aureliobarbosa Mar 1, 2024
8a28fb0
TST: add test_update_raises_without_intersection on DataFrame (#55509).
aureliobarbosa Mar 1, 2024
f08e92e
Rename variable.
aureliobarbosa Mar 1, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
DOC: add note on duplicate indices on parameter other (#55509)
  • Loading branch information
@aureliobarbosa
aureliobarbosa committed Feb 28, 2024
commit d7f63a1e16d5b8fc6602f0ea00cbd31368cee158
4 changes: 4 additions & 0 deletions pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8692,6 +8692,10 @@ def update(
dict.update : Similar method for dictionaries.
DataFrame.merge : For column(s)-on-column(s) operations.

Notes
--------
Copy link
Member

@datapythonista datapythonista Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having the ------- longer than the title used to make the CI crash. Not sure why the CI is happy now, but maybe worth making Notes and it the same length in case it fails again in the future.
Copy link
Contributor Author

@aureliobarbosa aureliobarbosa Mar 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it has the same size.
1. Duplicate indices on `other` are not supported and raises `ValueError`.

Examples
--------
>>> df = pd.DataFrame({"A": [1, 2, 3], "B": [400, 500, 600]})
Expand Down