PERF/CLN: Preserve concat(keys=range) RangeIndex level in the result #57755
+58 −37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mroeschke added Performance mroeschke changed the title concat(keys=range) RangeIndex level in the result 
rhshadrach reviewed Mar 8, 2024
Member
rhshadrach left a comment
rhshadrach left a comment There was a problem hiding this comment.
lgtm, just some nit picks.
| | ||
| | ||
| def test_frame_describe_tupleindex(): | ||
| @pytest.mark.parametrize("name", ["k", "key"]) |
Member
There was a problem hiding this comment.
Looks like this evolved from the original test. I don't think we need to be testing both.
| tm.assert_frame_equal(result, expected) | ||
| | ||
| @pytest.mark.parametrize("klass", [range, RangeIndex]) | ||
| def test_concat_preserves_rangeindex(self, klass): |
Member
There was a problem hiding this comment.
nit: I think you could parametrize with include_none=[True|False] and then have keys_length = 4 if include_none else 2
Member Author
There was a problem hiding this comment.
Sure thing. Parametrized this test over include_none instead
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
pandas-dev#57755) * PERF/CLN: Preserve RangeIndex level in the result * Whitespace * Whitespace * Fix test * Address review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Enforces #43485
Optimization found in #57441