Skip to content

Conversation

@Aloqeely
Copy link
Member

xref #58290
Places where I skipped match argument:
computation/test_eval.py and frame/test_query_eval.py as I couldn't get the tests to trigger the warning
plotting/test_datetimelike.py same reason as above.

The tests for internal things in util folder:
test_assert_produces_warning.py, test_deprecate_kwarg.py, test_deprecate_nonkeyword_arguments.py, test_deprecate.py

other places I skipped because it would complicate the logic (I.E. api/test_api.py's test_depr method.)

@Aloqeely Aloqeely requested a review from noatamir as a code owner April 24, 2024 03:27
@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Warnings Warnings that appear or should be added to pandas labels Apr 24, 2024
@mroeschke mroeschke added this to the 3.0 milestone Apr 24, 2024
@mroeschke mroeschke merged commit ba60432 into pandas-dev:main Apr 24, 2024
@mroeschke
Copy link
Member

mroeschke commented Apr 24, 2024

Thanks @Aloqeely (agreed that it would be nice to enforce match for assert_produces_warning)

pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
…pandas-dev#58396) * Fix for all FutureWarnings * Add match for most warnings * Cleaner code --------- Co-authored-by: Abdulaziz Aloqeely <52792999+DAzVise@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing pandas testing functions or related to the test suite Warnings Warnings that appear or should be added to pandas

2 participants