DEPR: lowercase strings w, d, b and c denoting frequencies in Week, Day, BusinessDay and CustomBusinessDay classes #58998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
natmokval changed the title w, d, b and c denoting frequencies in Week, Day, BusinessDay and CustomBusinessDay classes natmokval added Deprecate 
Contributor Author
| I deprecated lowercase strings |
Member
MarcoGorelli left a comment
MarcoGorelli left a comment There was a problem hiding this comment.
Looks good to me
Given that 2.3 isn't out yet, I wonder if it makes sense to get this in for 2.3, and then in 3.0 we make all these changes in one go and be done with it?
Member
| @mroeschke thoughts on 2.3 vs 3.0? |
MarcoGorelli approved these changes Jul 4, 2024
Member
MarcoGorelli left a comment
MarcoGorelli left a comment There was a problem hiding this comment.
If in doubt, let's just follow the usual process - deprecate in 3.0, remove thereafter - will merge then if there's no further objections
mroeschke approved these changes Jul 5, 2024
Member
| Thanks @natmokval and @MarcoGorelli |
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
xref #57986
d,bandcdenoting frequencies inDay,BusinessDayandCustomBusinessDayin favour ofD,BandCw,w-mon,w-tue, etc. denoting frequencies inWeekin favour ofW,W-MON,W-TUE, etc.we can deprecated lowercase strings
w,d,bandcforTimedeltain a separate PR