ENH: Globally enable Cython free-threading directive #59248
Merged
+9 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This is the Cython equivalent of adding a `Py_mod_gil` slot with `Py_MOD_GIL_NOT_USED` like we did in pandas-dev#59135.
mroeschke reviewed Jul 15, 2024
| endif | ||
| | ||
| cy = meson.get_compiler('cython') | ||
| if cy.version().version_compare('>=3.1.0') |
Member
There was a problem hiding this comment.
We may have to bump Cython first for this to get hit. Our build dependency is currently ~=3.0.5
Contributor Author
There was a problem hiding this comment.
Cython 3.1.0 has not been released yet. However, in #59136 we install Cython nightly to build 3.13 and free-threading wheels which supports this.
rgommers reviewed Jul 16, 2024
Contributor
rgommers left a comment
rgommers left a comment There was a problem hiding this comment.
This LGM modulo my one minor comment on add_global_arguments. The version comparison is right, and this doesn't require bumping the minimum Cython version.
mroeschke approved these changes Jul 16, 2024
Member
| Thanks @lysnikolaou |
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is the Cython equivalent of adding a
Py_mod_gilslot withPy_MOD_GIL_NOT_USEDlike we did in #59135.x-ref #59057.