PERF: avoid calling `DataFrame.dtypes` in loop #59573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

mroeschke merged 1 commit into pandas-dev:main from messense:patch-1

Aug 21, 2024

Contributor

messense commented Aug 21, 2024 •

edited

Loading

closes #xxxx (Replace xxxx with the GitHub issue number)
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added type annotations to new arguments/methods/functions.
Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

DataFrame.dtypes property isn't cheap to compute, this regressed DataFrame.eval performance massively (when upgrading from 2.1.2 to 2.2.2).

PERF: avoid calling DataFrame.dtypes in loop

9bcb32a

mroeschke approved these changes

View reviewed changes

mroeschke added the Performance label

mroeschke added this to the 3.0 milestone

mroeschke merged commit e1a79b2 into pandas-dev:main

Member

mroeschke commented Aug 21, 2024

Thanks @messense

messense deleted the patch-1 branch

August 22, 2024 01:42

jpn-- mentioned this pull request

Update to use pandas 2.x ActivitySim/activitysim#838

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment