Skip to content

BUG: Fix Ability to set both color and style in pandas plotting #59574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 22, 2024
+16 −1
Merged

BUG: Fix Ability to set both color and style in pandas plotting #59574

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4052620
BUG: Fix plotting set color style dict sametime
AntiKnot Aug 21, 2024
50b0c33
BUG: chore pre-commit inconsistent-namespace-usage
AntiKnot Aug 21, 2024
da34d46
BUG: Chore Conditional block
AntiKnot Aug 22, 2024
87fe105
Update doc/source/whatsnew/v3.0.0.rst
AntiKnot Aug 22, 2024
43ff2f9
BUG: Chore pre-commit sort whatsnew entries alphabetically
AntiKnot Aug 22, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
BUG: Chore Conditional block
  • Loading branch information
@AntiKnot
AntiKnot committed Aug 22, 2024
commit da34d4691805e9d2f7d0f394fb085fd46ff733fc
6 changes: 3 additions & 3 deletions pandas/plotting/_matplotlib/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,12 +451,12 @@ def _validate_color_args(self, color, colormap):
)

if self.style is not None:
if is_list_like(self.style):
if isinstance(self.style, dict):
styles = [self.style[col] for col in self.columns if col in self.style]
elif is_list_like(self.style):
styles = self.style
else:
styles = [self.style]
if isinstance(self.style, dict):
styles = [self.style[col] for col in self.columns if col in self.style]
# need only a single match
for s in styles:
if _color_in_style(s):
Expand Down