PERF: faster _coerce_to_data_and_mask() for astype("Float64") #60121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| Failures seem unrelated: |
Contributor Author
| The results from asv don't seem as impressive as the results above, guessing the scale of these tests is much smaller. |
Contributor Author
| @rhshadrach friendly ping |
jorisvandenbossche added Performance 
jorisvandenbossche approved these changes Oct 30, 2024
Member
jorisvandenbossche left a comment
jorisvandenbossche left a comment There was a problem hiding this comment.
This looks good to me, thanks a lot @auderson!
mroeschke reviewed Oct 30, 2024
| elif values.dtype.kind == "f": | ||
| # np.isnan is faster than is_numeric_na() for floats | ||
| # github issue: #60066 | ||
| mask = np.isnan(values) |
Member
There was a problem hiding this comment.
Could we ever get a masked float values here with pd.NA?
Member
There was a problem hiding this comment.
There is a
if not copy: values = np.asarray(values) else: values = np.array(values, copy=copy) above, so values is guaranteed to be a numpy array at this point
mroeschke approved these changes Oct 30, 2024
Member
| Thanks @auderson |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Use
np.isnanfor floats instead oflibmissing.is_numeric_na. Also add a fast path for booleansPrev:
New: