CI: Add Windows wheels for the free-threaded build #60146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
lysnikolaou commented Oct 30, 2024
lysnikolaou commented - Related to ENH: Python 3.13 free-threading support #59057
- All code checks passed.
mroeschke reviewed Nov 4, 2024
| before-build = "pip install delvewheel && bash {package}/scripts/cibw_before_build_windows.sh" | ||
| before-test = "bash {package}/scripts/cibw_before_test_windows.sh" | ||
| test-command = """ | ||
| set PANDAS_CI='1' && \ |
Member
There was a problem hiding this comment.
Could the PANDAS_CI be set in the before-test so that this section can re-use the test-command?
Contributor Author
There was a problem hiding this comment.
We could do that, yes, but all cibuildwheel custom configs include a different test-command. The Windows one has a slight difference as well. So I'm not sure if it's really worth it.
3 tasks
Contributor Author
| Can we merge this? Is there anything else I'd need to do before we can do it? |
mroeschke approved these changes Nov 12, 2024
Member
| Thanks @lysnikolaou |
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.