DOC: Clarify that DataFrame string formatters must return strings #6054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I am not 100% sure that string formatters must really return *unicode* strings (non-unicode strings seem to work, too), but I am leaving that because it's what is already documentated. Fixes pandas-dev#6052.
Contributor
| Disagree this "fixes" 6052, but it does help! I wonder if there is a good place in the docs to add more about this? I think probably we should catch bad input and re-raise it with better message... accepting string e.g. |
jreback added a commit that referenced this pull request Feb 14, 2014
DOC: Clarify that DataFrame string formatters must return strings
Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I am not 100% sure that string formatters must really return unicode strings
(non-unicode strings seem to work, too), but I am leaving that because it's
what is already documented.
related #6052