ENH: Add HalfYear offsets #60946
ENH: Add HalfYear offsets #60946
Conversation
| @rhshadrach I was able to add the half-year offset classes without too much added complexity. However, I haven't enabled them to be used as periods - that will take more code changes and tests. Do you recommend concluding this here or go all the way to supporting half-year periods? cc: @MarcoGorelli |
| @snitish - I think holding off on periods makes sense. This is already a sizable PR. |
pandas/_libs/tslibs/offsets.pyx Outdated
| # FIXME(cython#4446): python annotation here gives compile-time errors | ||
| # _default_starting_month: int | ||
| # _from_name_starting_month: int |
There was a problem hiding this comment.
Just curious if you've tried seeing if this is resolved.
There was a problem hiding this comment.
Unfortunately, this is not resolved yet. Still throws compile time errors when I uncomment those lines -
pandas/_libs/tslibs/offsets.cpython-310-darwin.so.p/pandas/_libs/tslibs/offsets.pyx.c:98384:21: error: use of undeclared identifier '__pyx_base' 98384 | __Pyx_XDECREF_SET(__pyx_base._default_starting_month, ((PyObject*)__pyx_t_2)); | ^ pandas/_libs/tslibs/offsets.cpython-310-darwin.so.p/pandas/_libs/tslibs/offsets.pyx.c:98384:21: error: use of undeclared identifier '__pyx_base'; did you mean '__pyx_k_base'? 98384 | __Pyx_XDECREF_SET(__pyx_base._default_starting_month, ((PyObject*)__pyx_t_2)); | ^~~~~~~~~~ | __pyx_k_base There was a problem hiding this comment.
I think the resolution would be type-hinting as:
_default_starting_month: typing.ClassVar[int] That's what I'm wondering will work with Cython 3.0.
There was a problem hiding this comment.
Ah yes, that seems to have fixed it. Thanks!
| Thanks again @snitish |
* ENH: Add HalfYear offsets * Add entry to whatsnew * Resolve cython typing issue
4 participants
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.