Skip to content

Conversation

@arthurlw
Copy link
Member

@arthurlw arthurlw requested a review from rhshadrach as a code owner April 14, 2025 05:24
ShauryaDusht added a commit to ShauryaDusht/pandas that referenced this pull request Apr 14, 2025
@mroeschke mroeschke mentioned this pull request Apr 14, 2025
5 tasks
Returns
-------
pandas.api.typing.ExponentialMovingWindowGroupby
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be kept

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback! Just to clarify, is there a particular reason to prefer pandas.api.typing.ExponentialMovingWindowGroupby over pandas.core.window.ExponentialMovingWindowGroupby?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pandas.core is not a public module

test.py Outdated
@@ -0,0 +1,19 @@
import pandas as pd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed

4 B 50
5 B 60
>>> df.groupby("Class").ewm(com=0.5).mean().reset_index(drop=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the reset_index call?

@mroeschke mroeschke added Docs Window rolling, ewma, expanding labels Apr 14, 2025
@mroeschke mroeschke added this to the 3.0 milestone Apr 14, 2025
@mroeschke mroeschke merged commit 183b327 into pandas-dev:main Apr 14, 2025
42 checks passed
@mroeschke
Copy link
Member

Thanks @arthurlw

snitish pushed a commit to snitish/pandas that referenced this pull request Jun 9, 2025
* updated doc and references * precommit * shortened summary * updated according to reviewer suggestions and removed test.py * Fixed docstring error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs Window rolling, ewma, expanding

2 participants