TST: Testing for mixed int/str Index #61349
Closed
+186 −66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…t_values_invalid_na_position
…t_values_with_missing
…xes\multi\test_setops.py
Member
| @xaris96 Can you fix the broken tests and remove all your debug files from this PR please? |
datapythonista added Testing 
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
mroeschke reviewed May 23, 2025
mroeschke requested changes May 23, 2025
Member
mroeschke left a comment
mroeschke left a comment There was a problem hiding this comment.
Please review the diff and consistently use these following conventions
- Use
inferred_typeto check for the newmixed-int-stringcase you added - If a test fails, do not
astypeorpytest.skip. Add anpytest.mark.xfailto the test instead
xaris96 force-pushed the issue-TM branch 6 times, most recently from 92e9e10 to a1eed56 Compare 
Member
| Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.