Skip to content

DOC/ENH: Holiday exclusion argument #61600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 13, 2025
Merged

DOC/ENH: Holiday exclusion argument #61600

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f054afb
added exclude_dates argument and test for holiday class
sharkipelago Jun 7, 2025
5a809e2
added entry on whatsnew
sharkipelago Jun 7, 2025
891b442
Merge remote-tracking branch 'upstream/main' into holiday-exclusion-a…
sharkipelago Jun 10, 2025
aa08735
moved pull request to v3.0.0 whatsnew
sharkipelago Jun 10, 2025
f019a5c
　updated exclude_dates to be [Timestamp] in constructor
sharkipelago Jun 10, 2025
bdbb555
updated Holiday.dates() to use difference method
sharkipelago Jun 10, 2025
5bca8c7
condensed type_checking import statement to 1 line
sharkipelago Jun 10, 2025
655ca4e
switchted exclude_dates type from list[Timestamp] to DatetimeIndex
sharkipelago Jun 10, 2025
f46c394
raise ValueError if exclude_dates is not DatetimeIndex
sharkipelago Jun 10, 2025
27cca3d
isinstance to check exclude_data
sharkipelago Jun 10, 2025
a9a745c
updated tests for DatetimeIndex type change
sharkipelago Jun 11, 2025
7710e43
Merge remote-tracking branch 'upstream/main' into holiday-exclusion-a…
sharkipelago Jun 11, 2025
5cfd599
added proper result-expected assertion pattern for tests
sharkipelago Jun 11, 2025
2d9e4c5
removed redundant asserts
sharkipelago Jun 12, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
isinstance to check exclude_data
  • Loading branch information
@sharkipelago
sharkipelago committed Jun 10, 2025
commit 27cca3d2056ea8a027cc4e8f14131c3652f73f62
2 changes: 1 addition & 1 deletion pandas/tseries/holiday.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ class from pandas.tseries.offsets, default None
self.observance = observance
assert days_of_week is None or type(days_of_week) == tuple
Copy link
Contributor Author

@sharkipelago sharkipelago Jun 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I also switch this to throw a ValueError on failing? Or would that be a separate PR?
Copy link
Member

@mroeschke mroeschke Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A separate PR would be better, thanks.
Copy link
Contributor Author

@sharkipelago sharkipelago Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this, should I open a new issue? Or just make another PR?
Copy link
Member

@mroeschke mroeschke Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just another PR is fine
self.days_of_week = days_of_week
if exclude_dates is not None and type(exclude_dates) != DatetimeIndex:
if not (exclude_dates is None or isinstance(exclude_dates, DatetimeIndex)):
raise ValueError("exclude_dates must be None or of type DatetimeIndex.")
self.exclude_dates = exclude_dates

Expand Down