DOC/ENH: Holiday days_of_week value error #61658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| I also edited the docstring a little bit as I was a bit confused what days_of_week was supposed to do from the docstring alone. Happy to delete the docstring edits if they don't make sense though. |
mroeschke reviewed Jun 16, 2025
doc/source/whatsnew/v3.0.0.rst Outdated
| - :class:`ArrowDtype` now supports ``pyarrow.JsonType`` (:issue:`60958`) | ||
| - :class:`DataFrameGroupBy` and :class:`SeriesGroupBy` methods ``sum``, ``mean``, ``median``, ``prod``, ``min``, ``max``, ``std``, ``var`` and ``sem`` now accept ``skipna`` parameter (:issue:`15675`) | ||
| - :class:`Holiday` has gained the constructor argument and field ``exclude_dates`` to exclude specific datetimes from a custom holiday calendar (:issue:`54382`) | ||
| - :class:`Holiday` constructor argument ``days_of_week`` will raise a ``ValueError`` when type is something other than ``None`` or ``tuple`` |
Member
There was a problem hiding this comment.
Suggested change
| - :class:`Holiday` constructor argument ``days_of_week`` will raise a ``ValueError`` when type is something other than ``None`` or ``tuple`` | |
| - :class:`Holiday` constructor argument ``days_of_week`` will raise a ``ValueError`` when type is something other than ``None`` or ``tuple`` (:issue:`61658`) |
Contributor Author
There was a problem hiding this comment.
should I specify that it's a PR since there is no original issue? Or :issue: can refer to both PRs and issues?
Member
There was a problem hiding this comment.
It applies to both issues and PRs
Contributor Author
There was a problem hiding this comment.
Got it, thanks for clarifying!
mroeschke approved these changes Jun 17, 2025
Member
| Thanks @sharkipelago |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Changed
Holidayconstructor argumentdays_of_weekto raise aValueErroron input of the incorrect type as discussed in #61600doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.