TST: Add regression tests for concat with non-ns DatetimeIndex units (GH#58471) #62304
Conversation
| @jbrockmendel I kindly request you to check the PR and let me know! |
| Is this AI? |
The description of the PR contains some things from AI. I'm sorry if its an problem. |
| Removed the AI part! Sorry for that. |
skalwaghe-56 force-pushed the fix-issue-58471 branch from 8918c62 to 08e33e9 Compare | @jbrockmendel Please check it now. Thanks! |
simonjayhawkins added the Testing skalwaghe-56 force-pushed the fix-issue-58471 branch 2 times, most recently from d9f5c25 to 2cd8c3a Compare | @rhshadrach Request you to kindly check this. |
| @skalwaghe-56 you don't need to ping us on every PR. We'll get to them all in due time. |
| @jbrockmendel Sorry Sir! |
skalwaghe-56 force-pushed the fix-issue-58471 branch 5 times, most recently from ffe118d to 5650319 Compare skalwaghe-56 force-pushed the fix-issue-58471 branch from 5650319 to 816c0d8 Compare 
simonjayhawkins left a comment
simonjayhawkins left a comment There was a problem hiding this comment.
Thanks @skalwaghe-56 for the PR.
Let's not add all these tests, just the minimum reproducible example, which in the linked issue looks like took a few contributors until it converged on anything that look like one!
skalwaghe-56 force-pushed the fix-issue-58471 branch from 816c0d8 to 6a832da Compare | @simonjayhawkins Thanks for your review! I've confirmed that we include just the minimum reproducible example. I've added 2 test which I think are necessary for this issue and to confirm that is fixed properly. Thanks! |
skalwaghe-56 force-pushed the fix-issue-58471 branch from 6a832da to 8e55e5a Compare 
rhshadrach added Needs Tests skalwaghe-56 force-pushed the fix-issue-58471 branch from 8e55e5a to fedaa40 Compare skalwaghe-56 force-pushed the fix-issue-58471 branch 5 times, most recently from 431fa2f to cfa7fd3 Compare skalwaghe-56 force-pushed the fix-issue-58471 branch 3 times, most recently from 8cb6204 to a0dd9e7 Compare skalwaghe-56 force-pushed the fix-issue-58471 branch from a0dd9e7 to 46f3d72 Compare skalwaghe-56 force-pushed the fix-issue-58471 branch 2 times, most recently from 01e5f63 to caf584d Compare skalwaghe-56 force-pushed the fix-issue-58471 branch from caf584d to 54adf8e Compare skalwaghe-56 force-pushed the fix-issue-58471 branch 2 times, most recently from b7b54f1 to c9d8049 Compare skalwaghe-56 force-pushed the fix-issue-58471 branch from c9d8049 to 0fa3118 Compare 
| @simonjayhawkins - you good here? |
| result = concat([first, second]) | ||
| tm.assert_frame_equal(result, expected) | ||
| | ||
| @pytest.mark.parametrize("unit", ["ns", "us", "ms", "s"]) |
There was a problem hiding this comment.
there is a fixture for this. OK for follow-up
There was a problem hiding this comment.
I couldn't find an existing fixture. Thanks!
There was a problem hiding this comment.
It is unit, you can just remove the @pytest.mark.parametrize line.
Line 1249 in 607e489
skalwaghe-56 force-pushed the fix-issue-58471 branch from d772523 to aa0077b Compare 4 participants
Adds regression tests for pandas issue #58471. Added a total of 3 tests. All tests are parameterized across datetime units (ns/us/ms/s) to verify consistent behavior.
Thanks!