TST: Replace ensure_clean with pytest temp_file/tmp_path fixture. #62599
+38 −37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mroeschke approved these changes Oct 6, 2025
Member
| Thanks @invain01 |
jzwick pushed a commit to jzwick/pandas that referenced this pull request Oct 8, 2025
eicchen pushed a commit to eicchen/pandas that referenced this pull request Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary of Changes: Replace ensure_clean with pytest temp_file/tmp_path
This PR refactors three test files to replace usage of the legacy
tm.ensure_cleancontext manager with pytest's modern temporary file fixtures (tmp_pathortemp_file). This change aligns with pandas testing best practices and improves test reliability and readability.Modified Files
pandas/tests/io/parser/test_c_parser_only.pypandas/tests/io/parser/dtypes/test_dtypes_basic.pypandas/tests/io/parser/common/test_read_errors.pyKey Changes
tm.ensure_cleanwere replaced with eithertmp_path(for custom filenames) ortemp_file(for generic temp files).