DEPR: inconsistent string parsing in DatetimeIndex.indexer_at_time #62945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

mroeschke merged 3 commits into pandas-dev:main from jbrockmendel:depr-between-time

Nov 4, 2025

+54 −3

Member

jbrockmendel commented Oct 31, 2025

closes BUG: string date parsing for at_time and indexer_at_time have many inconsistencies with indexer_at_time documentation; should be more like between_time #50839 (Replace xxxx with the GitHub issue number)
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added type annotations to new arguments/methods/functions.
Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

DEPR: inconsistent string parsing in DatetimeIndex.indexer_at_time

951a93f

mroeschke reviewed

View reviewed changes

pandas/tests/generic/test_finalize.py Show resolved Hide resolved

mroeschke reviewed

View reviewed changes

pandas/tests/frame/methods/test_at_time.py Outdated

      
     def test_at_time_ambiguous_format_deprecation(self):  
     # GH#50839  
     rng = date_range("1/1/2000", "1/5/2000", freq="5min")

Member

mroeschke Nov 3, 2025

Could we test with less data? (like end at 1/2/2000)

Member Author

jbrockmendel Nov 3, 2025

sure, will update

mroeschke added the Deprecate label

jbrockmendel added 2 commits

November 4, 2025 08:04

Merge branch 'main' into depr-between-time

8499ab2

Smaller test-data

78f747f

mroeschke added this to the 3.0 milestone

mroeschke approved these changes

View reviewed changes

mroeschke merged commit cd8dc38 into pandas-dev:main

42 checks passed

Member

mroeschke commented Nov 4, 2025

Thanks @jbrockmendel

github-actions bot mentioned this pull request

DEPR: List of deprecations to be removed in 4.0 #56596

Open

47 tasks

jbrockmendel deleted the depr-between-time branch

November 4, 2025 19:28

mittal-aakriti pushed a commit to mittal-aakriti/pandas that referenced this pull request

DEPR: inconsistent string parsing in DatetimeIndex.indexer_at_time (p…

7d06bc1

…andas-dev#62945)

mittal-aakriti pushed a commit to mittal-aakriti/pandas that referenced this pull request

DEPR: inconsistent string parsing in DatetimeIndex.indexer_at_time (p…

c7e4e5f

…andas-dev#62945)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment