Skip to content

ENH: clarify error message when multiplying bool times Timedelta #63139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 26, 2025
+14 −0
Merged

ENH: clarify error message when multiplying bool times Timedelta #63139

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e10d08
raise TypeError in __mul__
natmokval Nov 17, 2025
99e2351
Merge branch 'main' into bug-disallow-multiplication-bool-times-Timed…
natmokval Nov 21, 2025
2e09591
add test, fix typo
natmokval Nov 21, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add test, fix typo
  • Loading branch information
@natmokval
natmokval committed Nov 21, 2025
commit 2e0959193be4a2a1d03f3f899011009cceae3bb7
4 changes: 2 additions & 2 deletions pandas/_libs/tslibs/timedeltas.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2315,8 +2315,8 @@ class Timedelta(_Timedelta):
elif is_bool_object(other):
# GH#62316
raise TypeError(
"Cannot multiply Timedelta by bools. "
"Explicitly cast to integers instead."
"Cannot multiply Timedelta by bool. "
"Explicitly cast to integer instead."
)

return NotImplemented
Expand Down
6 changes: 6 additions & 0 deletions pandas/tests/scalar/timedelta/test_arithmetic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -970,6 +970,12 @@ def test_td_op_timedelta_timedeltalike_array(self, op, arr):
with pytest.raises(TypeError, match=msg):
op(arr, Timedelta("1D"))

def test_mul_bool_invalid(self):
# GH#62316
msg = "Cannot multiply Timedelta by bool. Explicitly cast to integer"
with pytest.raises(TypeError, match=msg):
Timedelta("1 day") * True


class TestTimedeltaComparison:
def test_compare_pytimedelta_bounds(self):
Expand Down
Loading