ENH: add method='dense' to rank #6343
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| (1) The tests I couldn't find were lurking in (2) I'm not sure what I'm doing which is breaking everything -- the code passes every test for me. Any obvious goofs I'm missing? |
Contributor
| nothing obvious.... |
Contributor Author
| Ah, got it. When I added It must have worked for me by fluke. Will fix. |
Contributor Author
| Managed to get it working last night but got the branch into a weird inconsistent state. Will make a new one instead. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This adds a
method='dense'option torankwhich does the same thing as the one inscipy.stats.rankdata: the first ranked group gets 1, the second 2, etc. Basically it ports the approach used inscipy.stats._rankdata_fusedto the pandas rankdata implementation.It also adds a few tests that the various methods do what they're supposed to, which I couldn't find a test for before.
closes #6333