CLN: Specialize assert_(np.array_equal(...)) #6368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| The proposed API change affects a function @KTAtkinson added this week. I changed all instances in master. Tests still pass locally. |
Contributor
| pls rebase on master - lots of recent changes |
Work on #6175. Work in progress. One more commit needed to finish; splitting to keep reasonably sized. * Changes assert_numpy_array_equals to assert_numpy_array_equal, for consistency with other methods. (API change of recently-added function) * Changes instances of assert_(np.array_equal(A,B)) to assert_numpy_array_equal(A,B) * Update release.rst to reflect work on #6175
Contributor Author
| @jreback: should be all set. |
jreback added a commit that referenced this pull request Feb 16, 2014
CLN: Specialize assert_(np.array_equal(...))
Contributor
| @bwignall thanks again! |
This was referenced Feb 16, 2014
gouthambs pushed a commit to gouthambs/pandas that referenced this pull request Mar 12, 2014
Work on pandas-dev#6175. This is the third (and final) "half" of the work started in pandas-dev#6368.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Work on #6175. Work in progress. One more commit needed to finish; splitting to keep reasonably sized.