Added dropna to docstring for HDFStore.put() #7063
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
HDFStore.put() method accepts dropna boolean parameter as it is passed directly to the internal _write_to_group() method, but it was not explicitly documented (as it is for append).
pandas/io/pytables.py Outdated
Contributor
There was a problem hiding this comment.
actually...can you copy the text from HDFStore.append method (the dropna option), as this is also settable by an option (and its the same option)
Contributor Author
| I wondered about that, since the append() method looks to have logic specifically looking at that option, but the put() method does not (- I've not actually tested it nor dug into the methods it calls to see if it was picked up there) |
Contributor
| no they go the same place, guess this wasn't documented :) |
… via option Added text to the HDFStore.put() method indicating dropna is settable via option, as for append()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
HDFStore.put() method accepts dropna boolean parameter as it is passed
directly to the internal _write_to_group() method, but it was not
explicitly documented (as it is for append).
Just added 2 lines to the put() method docstring to mention it explicitly.