BUG: Panel4D setitem by indexer to Series fails for mixed-dtype #8854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pandas/tests/test_panel4d.py Outdated
Contributor
There was a problem hiding this comment.
add the issue number (eg this pr as a comment)
Contributor
| pls squash, otherwise looks good |
pandas/core/indexing.py Outdated
Contributor
There was a problem hiding this comment.
actually this should be self.obj[item].axes[0]. The 0th axis. _stat_axis shouldn't work for a Panel4D because the Panel4D becomes a Panel (the self.obj[item]), and _stat_axis is 1. So it may happen to work. Maybe add a couple of tests here.
jreback added Compat 
Contributor
There was a problem hiding this comment.
why is any of this necessary? looks too complicated and error prone.
Contributor Author
There was a problem hiding this comment.
Agreed. This is turning out to be a lot less trivial than I originally thought.
Contributor
There was a problem hiding this comment.
why is this not always ._get_axis(0) ?
Contributor
| closing pls reopen if/when updated |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is another tweak to
_setitem_with_indexerthat allows it better to comprehend higher dimensional frames of mixed-dtype. With this tweak setting by indexer to a Series now works. Unfortunately setting to a DataFrame is still broken. I plan to open an issue for that.