Skip to content

WIP: add multi-multi index support to join #8898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

WIP: add multi-multi index support to join #8898

wants to merge 1 commit into from

Conversation

@thorwhalen
Copy link

@thorwhalen thorwhalen commented Nov 26, 2014

closes #6360
jreback
jreback reviewed Nov 26, 2014
View reviewed changes
pandas/core/index.py
Copy link
Contributor

@jreback jreback Nov 26, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this caused our build to fail :)
@jreback
Copy link
Contributor

jreback commented Nov 26, 2014

you need to remove the NotImplemented from the test suite to see if it passes the tests: https://github.com/pydata/pandas/blob/master/pandas/tools/tests/test_merge.py#L1193

also, think about adding a couple of more tests to exercise this (e.g. say an empty frame with the proper index on the merging axis), maybe a couple of simple examples too.
@jreback jreback added Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Enhancement Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Nov 26, 2014
@jreback jreback added this to the 0.16.0 milestone Nov 26, 2014
@jreback jreback mentioned this pull request Jan 30, 2015
Closed
@jreback jreback modified the milestones: 0.16.0, Next Major Release Mar 3, 2015
@jreback
Copy link
Contributor

jreback commented May 9, 2015

closing pls reopen if/when updated
@jreback jreback closed this May 9, 2015
@harisbal
Copy link
Contributor

harisbal commented Feb 25, 2017

Any chance to reopen this issue? It would be really useful to have this feature in pandas
Cheers
@jreback
Copy link
Contributor

jreback commented Feb 25, 2017

@harisbal this is a pull-request to fix an issue. you can certainly build on this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Enhancement Reshaping Concat, Merge/Join, Stack/Unstack, Explode

3 participants

@thorwhalen @jreback @harisbal