Skip to content

Conversation

@fvia
Copy link
Contributor

@fvia fvia commented Nov 29, 2014

ERROR: Failure: SyntaxError (Non-ASCII character '\xc3' in file /home/fvia/bloom/pandas/pandas/tests/test_format.py on line 825, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details (test_format.py, line 825)) 
@jreback
Copy link
Contributor

jreback commented Nov 29, 2014

looks good, can you audit all the files to see if this is case anywhere else?

is it recommended that EACH file have an encoding line? (or ONLY where we actually use unicode)?

where does this failure show up?

@jreback jreback added the Unicode Unicode strings label Nov 29, 2014
@jreback jreback added this to the 0.15.2 milestone Nov 29, 2014
@jreback jreback added the Testing pandas testing functions or related to the test suite label Nov 29, 2014
@fvia
Copy link
Contributor Author

fvia commented Nov 30, 2014

This failure shows up in python2, when somebody using python3 writes a non ASCII char.
Adding an encoding line in every file can reduce the number of bugs as more people are moving to python3.

@jorisvandenbossche
Copy link
Member

I also think it is just good practice to specify that in each file

@fvia
Copy link
Contributor Author

fvia commented Nov 30, 2014

I will add a encoding line to all files in test/

@jreback jreback merged commit fbcf5a4 into pandas-dev:master Dec 3, 2014
@jreback
Copy link
Contributor

jreback commented Dec 3, 2014

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing pandas testing functions or related to the test suite Unicode Unicode strings

3 participants