Skip to content

Calling qcut with too many duplicates now gives an informative error #9030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Calling qcut with too many duplicates now gives an informative error #9030

wants to merge 3 commits into from

Conversation

@edjoesu
Copy link

@edjoesu edjoesu commented Dec 6, 2014

Closes #7751.
jreback
jreback reviewed Dec 7, 2014
View reviewed changes
pandas/tools/tile.py
Copy link
Contributor

@jreback jreback Dec 7, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can do this as a set operation (set(bins)-set(unique(bins)) once you know that you have too many bins
Copy link
Author

@edjoesu edjoesu Dec 7, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't work. Say bins = [0,0,0,1,1,1]. We want [0,1]. (set(bins)-set(unique(bins)) gives set([]).

Something like it should, but I can't think of it at the moment.
@jreback jreback added Reshaping Concat, Merge/Join, Stack/Unstack, Explode Error Reporting Incorrect or improved errors from pandas labels Dec 7, 2014
@jreback
Copy link
Contributor

jreback commented Dec 7, 2014

  • needs a test
  • needs a release note (bug fix section)
@jreback jreback added this to the 0.16.0 milestone Jan 2, 2015
@jreback
Copy link
Contributor

jreback commented Jan 2, 2015

pls move the release note to v0.16.0. and rebase. thxs
jreback
jreback reviewed Jan 18, 2015
View reviewed changes
doc/source/whatsnew/v0.15.2.txt
Copy link
Contributor

@jreback jreback Jan 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls move this to 0.16.0
@jreback
Copy link
Contributor

jreback commented Jan 18, 2015

pls move the release note to 0.16.0 and rebase
@jreback jreback modified the milestones: 0.16.0, Next Major Release Mar 3, 2015
@jreback
Copy link
Contributor

jreback commented May 9, 2015

closing pls reopen if/when updated
@jreback jreback closed this May 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Error Reporting Incorrect or improved errors from pandas Reshaping Concat, Merge/Join, Stack/Unstack, Explode

2 participants

@edjoesu @jreback