Skip to content

Add lag parameter to autocorrelation #9192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

Add lag parameter to autocorrelation #9192

wants to merge 0 commits into from

Conversation

@omtinez
Copy link
Contributor

@omtinez omtinez commented Jan 2, 2015

Add lag parameter to autocorrelation, default to lag-1 autocorrelation so existing code will work unchanged.
@omtinez
Copy link
Contributor Author

omtinez commented Jan 3, 2015

This is not good! Failure unrelated to my commit:

FAIL: test_tquery (pandas.io.tests.test_sql.TestXMySQL)

Traceback (most recent call last):
File "/home/travis/build/pydata/pandas/pandas/io/tests/test_sql.py", line 2238, in test_tquery
tm.assert_series_equal(result, expected)
File "/home/travis/build/pydata/pandas/pandas/util/testing.py", line 674, in assert_series_equal
assert_almost_equal(left.values, right.values, check_less_precise)
File "testing.pyx", line 58, in pandas._testing.assert_almost_equal (pandas/src/testing.c:2556)
File "testing.pyx", line 93, in pandas._testing.assert_almost_equal (pandas/src/testing.c:1794)
File "testing.pyx", line 140, in pandas._testing.assert_almost_equal (pandas/src/testing.c:2390)
AssertionError: expected -1.00016 but got -1.00015, with decimal 5

Have you seen this before?
@omtinez omtinez closed this Jan 4, 2015
@omtinez omtinez reopened this Jan 4, 2015
@jreback
Copy link
Contributor

jreback commented Jan 5, 2015

@omtinez pls add a release note 0.16.0 enhancements section. and then squash. looks ok otherwise.
@jreback jreback added Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Numeric Operations Arithmetic, Comparison, and Logical operations labels Jan 5, 2015
@jreback jreback added this to the 0.16.0 milestone Jan 5, 2015
@jreback
Copy link
Contributor

jreback commented Jan 10, 2015

ok this seems ok. pls rebase on master and squash. ping when green.
@omtinez omtinez closed this Jan 14, 2015
@omtinez
Copy link
Contributor Author

omtinez commented Jan 14, 2015

Sorry about the mess, new to Git. I squashed the changes and now both autocorrelation-lag and master in my repo should reflect all of my desired changes.
@TomAugspurger
Copy link
Contributor

TomAugspurger commented Jan 14, 2015

@omtinez looks like you may have closed the pull request on accident. Could you reopen it?
@omtinez
Copy link
Contributor Author

omtinez commented Jan 14, 2015

For some reason, github closed my pull request and now sees zero commits in my branch. I tried doing a git push -f just to see if github would pick up my commit then but no dice: https://github.com/omtinez/pandas/commit/25b6b3747dd9835ad18350ea4717e91a16619a72

Github won't let me reopen unless it sees the commit, is there a way to fix this or do I need to open a new pull request?
@omtinez omtinez mentioned this pull request Jan 22, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Numeric Operations Arithmetic, Comparison, and Logical operations

3 participants

@omtinez @jreback @TomAugspurger