-
- Notifications
You must be signed in to change notification settings - Fork 19.4k
FIX: Fix encoding to allow StataReader to read urls #9245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| This fix is not finished - mostly using it to document the issue. The StringIO is returning unicode while unpack expects bytes (or string on Python 2). This simply encodes the unicode to a new StringIO object, and is very ugly. |
1ba5898 to bcef1e9 Compare 7056f0a to b1f0fb7 Compare | One timed out, the others all passed, so it seems ready, barring other issues in the method I used. |
doc/source/whatsnew/v0.16.0.txt Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make these double back ticks on both sides of the word
| minor comment, I restarted the stalled job |
| @jreback Looks good. Let me know if you need me to rebase. |
Fix encoding so that StataReader can correctly read URLs closes pandas-dev#9231
FIX: Fix encoding to allow StataReader to read urls
| @bashtage thanks! |
Fixes pandas-dev#48700 Regressed in pandas-dev#9245 Regressed in 2f0ada3
Fixes pandas-dev#48700 Regressed in pandas-dev#9245 Regressed in 2f0ada3
Fixes pandas-dev#48700 Regressed in pandas-dev#9245 Regressed in 2f0ada3
Fixes pandas-dev#48700 Regressed in pandas-dev#9245 Regressed in 2f0ada3
Fixes pandas-dev#48700 Regressed in pandas-dev#9245 Regressed in 2f0ada3
Fixes pandas-dev#48700 Regressed in pandas-dev#9245 Regressed in 2f0ada3
Fixes pandas-dev#48700 Regressed in pandas-dev#9245 Regressed in 2f0ada3
Fixes pandas-dev#48700 Regressed in pandas-dev#9245 Regressed in 2f0ada3
Fixes pandas-dev#48700 Refs pandas-dev#9245 Refs pandas-dev#37639 Regressed in 6d1541e
Fixes pandas-dev#48700 Refs pandas-dev#9245 Refs pandas-dev#37639 Regressed in 6d1541e
Fixes pandas-dev#48700 Refs pandas-dev#9245 Refs pandas-dev#37639 Regressed in 6d1541e
Fixes pandas-dev#48700 Refs pandas-dev#9245 Refs pandas-dev#37639 Regressed in 6d1541e
Fixes pandas-dev#48700 Refs pandas-dev#9245 Refs pandas-dev#37639 Regressed in 6d1541e
Fixes pandas-dev#48700 Refs pandas-dev#9245 Refs pandas-dev#37639 Regressed in 6d1541e
Fixes pandas-dev#48700 Refs pandas-dev#9245 Refs pandas-dev#37639 Regressed in 6d1541e
Fixes pandas-dev#48700 Refs pandas-dev#9245 Refs pandas-dev#37639 Regressed in 6d1541e
Fix encoding so that StataReader can correctly read URLs
closes #9231