Skip to content

BUG: declare and use self.unique_check #9526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

BUG: declare and use self.unique_check #9526

wants to merge 1 commit into from

Conversation

@toobaz
Copy link
Member

@toobaz toobaz commented Feb 19, 2015

... unless I'm really missing something trivial...
@jreback
Copy link
Contributor

jreback commented Feb 19, 2015

u aren't using it
is it used anywhere?
is there any perf impact?
@toobaz
Copy link
Member Author

toobaz commented Feb 19, 2015

The attribute is used at line
https://github.com/pydata/pandas/blob/a064c7d976f5e93ea91a23f97690f1d180a03948/pandas/index.pyx#L209
The performance impact is virtually null: after the test fails, _ensure_mapping_populated ends up being called, it sees the index is already initialized and stops. So unless there are plans to make more fine grained initializations, I think one could just remove anything related to it, and make "get" of "is_unique" simply check self.initialized and in case call self.initialize.
@jreback jreback added Performance Memory or execution speed performance API Design labels Mar 6, 2015
@jreback
Copy link
Contributor

jreback commented May 9, 2015

closing pls reopen if/when updated
@jreback jreback closed this May 9, 2015
@toobaz toobaz mentioned this pull request May 14, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API Design Performance Memory or execution speed performance

2 participants

@toobaz @jreback