Skip to content

ENH Make year and quarter dash-separatable #9701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2015
Merged

ENH Make year and quarter dash-separatable #9701

merged 1 commit into from
Mar 26, 2015

Conversation

@williamhogman
Copy link
Contributor

@williamhogman williamhogman commented Mar 22, 2015

This closes #9688 by making years and quarters separable by dashes.
@jreback jreback added Enhancement Period Period data type labels Mar 23, 2015
jreback
jreback reviewed Mar 23, 2015
View reviewed changes
pandas/tseries/tests/test_offsets.py Outdated
Copy link
Contributor

@jreback jreback Mar 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the issue in a comment here
Copy link
Contributor

@jreback jreback Mar 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there possibilities that it shouldn't match?
@williamhogman
Copy link
Contributor Author

williamhogman commented Mar 23, 2015

@jreback I think I've adjusted them accordingly, although I'm not quite sure about the how you want the test-case class. Anyhow, tell me if it looks OK so I can rebase it :)
jreback
jreback reviewed Mar 25, 2015
View reviewed changes
pandas/tseries/tests/test_offsets.py
Copy link
Contributor

@jreback jreback Mar 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the issue number as a comment here
@jreback jreback added this to the 0.16.1 milestone Mar 25, 2015
@jreback
Copy link
Contributor

jreback commented Mar 25, 2015

minor comments, pls squash as well. thanks. ping when green.
@williamhogman
ENH Make year and quarter dash-separatable
91c63a6 
This closes pandas-dev#9688 by making years and quarters separable by dashes.
@williamhogman williamhogman force-pushed the feature-dashed-quarters branch from c620a51 to 91c63a6 Compare March 26, 2015 05:55
@williamhogman
Copy link
Contributor Author

williamhogman commented Mar 26, 2015

@jreback That should do it, commits are now squashed.
jreback added a commit that referenced this pull request Mar 26, 2015
@jreback
Merge pull request #9701 from williamhogman/feature-dashed-quarters
8d2818e 
ENH Make year and quarter dash-separatable
@jreback jreback merged commit 8d2818e into pandas-dev:master Mar 26, 2015
@jreback
Copy link
Contributor

jreback commented Mar 26, 2015

thank you!
@williamhogman
Copy link
Contributor Author

williamhogman commented Mar 26, 2015

Happy to help, pandas has saved my ass too many times to count.

William Rudenmalm
tel. +46 70 263 86 33
www.whn.se

On Thu, Mar 26, 2015 at 10:50 AM, jreback notifications@github.com wrote:

thank you!

—
Reply to this email directly or view it on GitHub
#9701 (comment).
@dr-leo dr-leo mentioned this pull request Apr 10, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Period Period data type

2 participants

@williamhogman @jreback