Skip to content

TST: Check index names #9972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2015
Merged

TST: Check index names #9972

merged 1 commit into from
Apr 28, 2015

Conversation

@sinhrks
Copy link
Member

@sinhrks sinhrks commented Apr 23, 2015

Derived from #9862. Added check_names kw to followings testing functions:

  • assert_index_equal (default=True).
  • assert_series_equal (default=True). Maybe the same option can be used to check Series.name in the future, otherwise it may better to choose separate name such as check_index_name.
  • assert_panelnd_equal (default=False). We have to check following ToDo to specify default=True.
  • https://github.com/pydata/pandas/blob/master/pandas/util/testing.py#L771
  • assert_frame_equal is untouched as it already has the kw. Not refactored the logic because it has a path which doesn't use assert_index_equal internally.

Looked through test cases which have to be check_names=False, and added name check tests.
@sinhrks sinhrks added Testing pandas testing functions or related to the test suite Indexing Related to indexing on series/frames, not to indexes themselves labels Apr 24, 2015
@jreback jreback added this to the 0.16.1 milestone Apr 24, 2015
jreback added a commit that referenced this pull request Apr 28, 2015
@jreback
Merge pull request #9972 from sinhrks/index_name
eb64190 
TST: Check index names
@jreback jreback merged commit eb64190 into pandas-dev:master Apr 28, 2015
@jreback
Copy link
Contributor

jreback commented Apr 28, 2015

@sinhrks thanks!
@sinhrks sinhrks deleted the index_name branch April 29, 2015 01:22
@sinhrks sinhrks mentioned this pull request May 15, 2015
Closed
@sinhrks sinhrks mentioned this pull request Jun 4, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Indexing Related to indexing on series/frames, not to indexes themselves Testing pandas testing functions or related to the test suite

2 participants

@sinhrks @jreback