Fix API call for filtering albums by year#50
Open
pR0Ps wants to merge 1 commit intopeguerosdc:masterfrom
Open
Conversation
This changes the parameters from `to`/`from` to `toYear`/`fromYear` as defined in the Subsonic API docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the year filtering parameters from
to/fromtotoYear/fromYearas defined in the Subsonic API docs.Note that I haven't tested this, I just saw the error in the version deployed at https://subplayer.netlify.app/ and did some basic searching to track down why it was failing.EDIT: got it building locally and confirmed that the fix works against a local Supysonic v0.7.8 server